Add extra flags #340
Closed
Add extra flags #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @filipopo, Thank you for the optimization work - reducing the image from 2.58GB to 2.06GB is impressive! Unfortunately, I need to close this PR because:
As a proof-of-concept repository, I want to keep the Dockerfile minimal and immediately understandable for first-time users, even if it means larger image sizes. The optimization flags ( Your PR is still valuable as it documents these optimizations for anyone who needs production-level performance! Thanks for all your contributions to the project! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some changes that reduce the image size and make the build faster
dnf:
--nodocs doesn't install documentation files, can be be checked with e.g rpm -qd unzip
Using install_weak_deps=0 installs about 110 less packages, can be checked with dnf install
clean all will remove package install cache, I also added in a rm -rf for the "best practices"
pip:
--no-cache-dir kinda self-explanatory
-U will upgrade the package if there's a new release
Overall the difference in the image size is 2.58GB without, versus 2.06GB with the new flags
I also corrected this
=> WARN: FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 1)Of course I ran a basic test to make sure that it still works